ARROW-8168:[Java][Plasma] Improve Java Plasma client off-heap memory usage #6715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winningsix
reviewed
Mar 25, 2020
| * @param timeoutMs time in milliseconfs to wait before this request time out. | ||
| * @param isMetadata get this object's metadata or data. | ||
| */ | ||
| public ByteBuffer getByteBuffer(byte[] objectId, int timeoutMs, boolean isMetadata) { |
There was a problem hiding this comment.
Hint: rename getByteBuffer as getObjAsByteBuffer?
There was a problem hiding this comment.
Yes, it's more meaningful.
| @@ -46,11 +46,6 @@ public static native ByteBuffer create(long conn, byte[] objectId, int size, byt | |||
|
|
|||
| public static native boolean contains(long conn, byte[] objectId); | |||
|
|
|||
| public static native void fetch(long conn, byte[][] objectIds); | |||
There was a problem hiding this comment.
Considering the backward compatibility, we should keep those APIs and mark as deprecated. Thoughts?
There was a problem hiding this comment.
These two APIs have native declare, but implementation has been removed.
There was a problem hiding this comment.
So it's not for this JIRA? Better file a separated PR addressing it.
…entation." This reverts commit e7957b7.
|
LGTM (no-binding) @wesm could you take a further look at this? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement create() and getByteBuffer() method, Java client could use off-heap ByteBuffer to avoid memory copy.