ARROW-8183: [C++][Python][FlightRPC] Expose transport error metadata #6747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymurr
changed the title
lidavidm
requested changes
Mar 29, 2020
cpp/src/arrow/flight/internal.cc
Outdated
| *status = Status(code, message); | ||
| const auto grpc_detail_val = trailers.find(kBinaryErrorDetailsKey); | ||
| std::shared_ptr<FlightStatusDetail> flightStatusDetail( | ||
| new FlightStatusDetail(FlightStatusCode::Unavailable)); |
There was a problem hiding this comment.
We shouldn't use Unavailable. We should probably add a new enum variant for when there's no other applicable code, or otherwise default to INTERNAL.
There was a problem hiding this comment.
fixed in most recent path
lidavidm
reviewed
Mar 29, 2020
|
Thanks a lot for the comments @lidavidm! will address and get back to you. |
rymurr
force-pushed
the
ARROW-8183
branch
3 times, most recently
from
fa50795
to
5b740b3
Compare
This is the C++ and Python version of ARROW-8181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the C++ and Python version of ARROW-8181