ARROW-8209: [Python] Improve error message when trying to access duplicate Table column #6831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/pyarrow/tests/test_table.py
Outdated
|
|
||
| assert table.schema.get_field_index('a') == -1 | ||
|
|
||
| # Not guaranteed to be sorted |
There was a problem hiding this comment.
should we guarantee it in the python API? (eg by just putting a return sorted(...) around the return value in get_all_field_indices)
There was a problem hiding this comment.
I may as well sort in the C++ function. Stand by
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds small binding for
Schema::GetAllFieldIndices