Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-8687: [Java] Remove references to io.netty.buffer.ArrowBuf #7093

Closed
wants to merge 1 commit into from

Conversation

rymurr
Copy link
Contributor

@rymurr rymurr commented May 4, 2020

Some references to io.netty.buffer.ArrowBuf were missed off
in ARROW-8229. This cleans up the last remaining references.

Some references to `io.netty.buffer.ArrowBuf` were missed off
in ARROW-8229. This cleans up the last remaining references.
@github-actions
Copy link

github-actions bot commented May 4, 2020

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@rymurr
Copy link
Contributor Author

rymurr commented May 4, 2020

@liyafan82 just noticed a few entries of io.netty.buffer.ArrowBuf after the recent merge of your patch to move it to com.apache.arrow.memory.ArrowBuf

@rymurr rymurr changed the title [Java] ARROW-8687: Remove references to io.netty.buffer.ArrowBuf ARROW-8687:[Java] Remove references to io.netty.buffer.ArrowBuf May 4, 2020
@rymurr rymurr changed the title ARROW-8687:[Java] Remove references to io.netty.buffer.ArrowBuf ARROW-8687: [Java] Remove references to io.netty.buffer.ArrowBuf May 4, 2020
@github-actions
Copy link

github-actions bot commented May 4, 2020

Copy link
Contributor

@liyafan82 liyafan82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for your effort.

@rymurr
Copy link
Contributor Author

rymurr commented May 4, 2020

Thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants