Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-9109: [Python][Packaging] Enable S3 support in manylinux wheels #7471

Closed
wants to merge 4 commits into from
Closed

ARROW-9109: [Python][Packaging] Enable S3 support in manylinux wheels #7471

wants to merge 4 commits into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Jun 17, 2020

No description provided.

@pitrou
Copy link
Member Author

pitrou commented Jun 17, 2020

@github-actions crossbow submit -g wheel

@github-actions
Copy link

Revision: 0517d82

Submitted crossbow builds: ursa-labs/crossbow @ actions-326

Task Status
wheel-manylinux1-cp35m Azure
wheel-manylinux1-cp36m Azure
wheel-manylinux1-cp37m Azure
wheel-manylinux1-cp38 Azure
wheel-manylinux2010-cp35m Azure
wheel-manylinux2010-cp36m Azure
wheel-manylinux2010-cp37m Azure
wheel-manylinux2010-cp38 Azure
wheel-manylinux2014-cp35m Azure
wheel-manylinux2014-cp36m Azure
wheel-manylinux2014-cp37m Azure
wheel-manylinux2014-cp38 Azure
wheel-osx-cp35m TravisCI
wheel-osx-cp36m TravisCI
wheel-osx-cp37m TravisCI
wheel-osx-cp38 TravisCI
wheel-win-cp35m Appveyor
wheel-win-cp36m Appveyor
wheel-win-cp37m Appveyor
wheel-win-cp38 Appveyor

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-9109

@pitrou
Copy link
Member Author

pitrou commented Jun 17, 2020

@github-actions crossbow submit -g wheel

@github-actions
Copy link

Revision: 282de25

Submitted crossbow builds: ursa-labs/crossbow @ actions-327

Task Status
wheel-manylinux1-cp35m Azure
wheel-manylinux1-cp36m Azure
wheel-manylinux1-cp37m Azure
wheel-manylinux1-cp38 Azure
wheel-manylinux2010-cp35m Azure
wheel-manylinux2010-cp36m Azure
wheel-manylinux2010-cp37m Azure
wheel-manylinux2010-cp38 Azure
wheel-manylinux2014-cp35m Azure
wheel-manylinux2014-cp36m Azure
wheel-manylinux2014-cp37m Azure
wheel-manylinux2014-cp38 Azure
wheel-osx-cp35m TravisCI
wheel-osx-cp36m TravisCI
wheel-osx-cp37m TravisCI
wheel-osx-cp38 TravisCI
wheel-win-cp35m Appveyor
wheel-win-cp36m Appveyor
wheel-win-cp37m Appveyor
wheel-win-cp38 Appveyor

@pitrou
Copy link
Member Author

pitrou commented Jun 17, 2020

@github-actions crossbow submit -g wheel

@github-actions
Copy link

Revision: f287017

Submitted crossbow builds: ursa-labs/crossbow @ actions-328

Task Status
wheel-manylinux1-cp35m Azure
wheel-manylinux1-cp36m Azure
wheel-manylinux1-cp37m Azure
wheel-manylinux1-cp38 Azure
wheel-manylinux2010-cp35m Azure
wheel-manylinux2010-cp36m Azure
wheel-manylinux2010-cp37m Azure
wheel-manylinux2010-cp38 Azure
wheel-manylinux2014-cp35m Azure
wheel-manylinux2014-cp36m Azure
wheel-manylinux2014-cp37m Azure
wheel-manylinux2014-cp38 Azure
wheel-osx-cp35m TravisCI
wheel-osx-cp36m TravisCI
wheel-osx-cp37m TravisCI
wheel-osx-cp38 TravisCI
wheel-win-cp35m Appveyor
wheel-win-cp36m Appveyor
wheel-win-cp37m Appveyor
wheel-win-cp38 Appveyor

@pitrou pitrou requested a review from kszucs June 17, 2020 17:52
@pitrou pitrou marked this pull request as ready for review June 17, 2020 18:56
@pitrou
Copy link
Member Author

pitrou commented Jun 17, 2020

It seems like everything is working fine here.

@pitrou
Copy link
Member Author

pitrou commented Jun 17, 2020

This grows the manylinux wheel sizes by about 2-3 MB (from ~13MB to ~15-16MB). It think it's reasonable.

@kszucs
Copy link
Member

kszucs commented Jun 17, 2020

This grows the manylinux wheel sizes by about 2-3 MB (from ~13MB to ~15-16MB). It think it's reasonable.

Yes, I expected more.

@wesm
Copy link
Member

wesm commented Jun 17, 2020

Very reasonable. Thanks @pitrou!

@kszucs
Copy link
Member

kszucs commented Jun 17, 2020 •
edited
Loading

Quickly went through it and it LGTM. I can give it a more thorough review tomorrow.

kszucs
kszucs reviewed Jun 18, 2020
View reviewed changes
python/manylinux1/scripts/build_boost.sh

# Bintray is much faster but can fail because of limitations
curl -sL https://dl.bintray.com/boostorg/release/${BOOST_VERSION}/source/boost_${BOOST_VERSION_UNDERSCORE}.tar.bz2 -o /${ARCHIVE_NAME} \
|| curl -sL https://sourceforge.net/projects/boost/files/boost/${BOOST_VERSION}/boost_${BOOST_VERSION_UNDERSCORE}.tar.bz2 -o /${ARCHIVE_NAME}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I've created https://bintray.com/apache/arrow/boost-mirror and mirrored Boost 1.73.0 as https://apache.bintray.com/arrow/boost/1.73.0/boost_1_73_0.tar.bz2 .

We can use this to save the official Boost download resource.

kszucs
kszucs approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OSX failure is unrelated.

@pitrou pitrou closed this in d04f54b Jun 18, 2020
@pitrou pitrou deleted the ARROW-9109-manylinux-s3 branch June 18, 2020 08:58
@asfimport asfimport mentioned this pull request Jun 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou left review comments

@kszucs kszucs kszucs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pitrou @kszucs @wesm @kou