ARROW-9598: [C++][Parquet] Fix writing nullable structs #7862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emkornfield
changed the title
frankdjx
reviewed
Jul 31, 2020
|
@wesm just wanted to make sure this is on your radar, it would be nice to get it into the patch release. |
wesm
approved these changes
Aug 10, 2020
|
|
||
| CheckSimpleRoundtrip( | ||
| ::arrow::Table::Make(std::make_shared<::arrow::Schema>( | ||
| std::vector<std::shared_ptr<::arrow::Field>>{links}), |
There was a problem hiding this comment.
in the future you could do ::arrow::schema({links})
|
Merging. Failure seems unrelated |
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
Aug 11, 2020
Traverse the node hierarchy to ensure we capture the right value count. Closes apache#7862 from emkornfield/verify_parquetfg Authored-by: Micah Kornfield <emkornfield@gmail.com> Signed-off-by: Wes McKinney <wesm@apache.org>
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
Aug 11, 2020
Traverse the node hierarchy to ensure we capture the right value count. Closes apache#7862 from emkornfield/verify_parquetfg Authored-by: Micah Kornfield <emkornfield@gmail.com> Signed-off-by: Wes McKinney <wesm@apache.org>
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
Aug 12, 2020
Traverse the node hierarchy to ensure we capture the right value count. Closes apache#7862 from emkornfield/verify_parquetfg Authored-by: Micah Kornfield <emkornfield@gmail.com> Signed-off-by: Wes McKinney <wesm@apache.org>
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
Aug 17, 2020
Traverse the node hierarchy to ensure we capture the right value count. Closes apache#7862 from emkornfield/verify_parquetfg Authored-by: Micah Kornfield <emkornfield@gmail.com> Signed-off-by: Wes McKinney <wesm@apache.org>
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
Aug 17, 2020
Traverse the node hierarchy to ensure we capture the right value count. Closes apache#7862 from emkornfield/verify_parquetfg Authored-by: Micah Kornfield <emkornfield@gmail.com> Signed-off-by: Wes McKinney <wesm@apache.org>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Traverse the node hierarchy to ensure we capture the right value count. Closes apache#7862 from emkornfield/verify_parquetfg Authored-by: Micah Kornfield <emkornfield@gmail.com> Signed-off-by: Wes McKinney <wesm@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traverse the node hierarchy to ensure we capture the right value count.