ARROW-9744: [Python] Fix build failure on aarch64 #7982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyarrow just uses SetupCxxFlags.cmake. It doesn't use DefineOptions.cmake. We need to define ARROW_ARMV8_ARCH in pyarrow too. It's defined in DefineOptions.cmake.
|
+1 |
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Sep 8, 2020
pyarrow uses only SetupCxxFlags.cmake. It doesn't use DefineOptions.cmake. We need to define ARROW_ARMV8_ARCH in pyarrow too. It's defined in DefineOptions.cmake. Closes apache#7982 from kou/python-aarch64 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Oct 16, 2020
pyarrow uses only SetupCxxFlags.cmake. It doesn't use DefineOptions.cmake. We need to define ARROW_ARMV8_ARCH in pyarrow too. It's defined in DefineOptions.cmake. Closes apache#7982 from kou/python-aarch64 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
pyarrow uses only SetupCxxFlags.cmake. It doesn't use DefineOptions.cmake. We need to define ARROW_ARMV8_ARCH in pyarrow too. It's defined in DefineOptions.cmake. Closes apache#7982 from kou/python-aarch64 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyarrow uses only SetupCxxFlags.cmake. It doesn't use
DefineOptions.cmake. We need to define ARROW_ARMV8_ARCH in pyarrow
too. It's defined in DefineOptions.cmake.