ARROW-10125: [R] Int64 downcast check doesn't consider all chunks #8292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the quick fix @nealrichardson |
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
Oct 1, 2020
The ArraysCanFitInteger function was erroneously exiting the loop over all chunks early after the first `true` was found, rather than bailing on the first `false`. All chunks need to fit in order to be able to downcast. Closes apache#8292 from nealrichardson/r-fix-int64-downcast Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Oct 16, 2020
The ArraysCanFitInteger function was erroneously exiting the loop over all chunks early after the first `true` was found, rather than bailing on the first `false`. All chunks need to fit in order to be able to downcast. Closes apache#8292 from nealrichardson/r-fix-int64-downcast Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
The ArraysCanFitInteger function was erroneously exiting the loop over all chunks early after the first `true` was found, rather than bailing on the first `false`. All chunks need to fit in order to be able to downcast. Closes apache#8292 from nealrichardson/r-fix-int64-downcast Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ArraysCanFitInteger function was erroneously exiting the loop over all chunks early after the first
truewas found, rather than bailing on the firstfalse. All chunks need to fit in order to be able to downcast.