ARROW-10310: [C++][Gandiva] Add single argument round() in Gandiva #8467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pprudhvi
reviewed
Oct 16, 2020
pprudhvi
reviewed
Oct 16, 2020
pprudhvi
reviewed
Oct 16, 2020
|
LGTM, added comments to rename macros. |
sgnkc
added a commit
to dremio/arrow
that referenced
this pull request
Oct 19, 2020
Closes apache#8467 from sagnikc-dremio/round-single and squashes the following commits: 9d11898 <Sagnik Chakraborty> ARROW-10310: Add single argument round() in Gandiva Authored-by: Sagnik Chakraborty <sagnikc@dremio.com> Signed-off-by: Praveen <praveen@dremio.com>
kszucs
pushed a commit
that referenced
this pull request
Oct 19, 2020
Closes #8467 from sagnikc-dremio/round-single and squashes the following commits: 9d11898 <Sagnik Chakraborty> ARROW-10310: Add single argument round() in Gandiva Authored-by: Sagnik Chakraborty <sagnikc@dremio.com> Signed-off-by: Praveen <praveen@dremio.com>
david1437
pushed a commit
to david1437/arrow
that referenced
this pull request
Nov 9, 2020
Closes apache#8467 from sagnikc-dremio/round-single and squashes the following commits: 9d11898 <Sagnik Chakraborty> ARROW-10310: Add single argument round() in Gandiva Authored-by: Sagnik Chakraborty <sagnikc@dremio.com> Signed-off-by: Praveen <praveen@dremio.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Closes apache#8467 from sagnikc-dremio/round-single and squashes the following commits: 9d11898 <Sagnik Chakraborty> ARROW-10310: Add single argument round() in Gandiva Authored-by: Sagnik Chakraborty <sagnikc@dremio.com> Signed-off-by: Praveen <praveen@dremio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.