-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-10575: [Rust] Rename union.rs to be cosistent with other arrays #8656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
@@ -121,8 +121,8 @@ pub use self::array_primitive::PrimitiveArray; | |||
pub use self::array_string::LargeStringArray; | |||
pub use self::array_string::StringArray; | |||
pub use self::array_struct::StructArray; | |||
pub use self::array_union::UnionArray; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looks like we could also do the same thing (move NullArray
from null.rs
to null_array.rs
), though as a different PR. I think this PR is a good improvement itself.
The https://github.com/apache/arrow/pull/8656/checks?check_run_id=1394039681 build on travis seems to have been queued for many hours at this point. I am thinking that merging this PR anyways would be fine. Any thoughts? |
Yea, I agree. This is a pretty low risk given the nature of the PR and that all the other CI runs were fine. |
Closes apache#8656 from paddyhoran/rename-union Authored-by: Paddy Horan <paddyhoran@hotmail.com> Signed-off-by: alamb <andrew@nerdnetworks.org>
Closes apache#8656 from paddyhoran/rename-union Authored-by: Paddy Horan <paddyhoran@hotmail.com> Signed-off-by: alamb <andrew@nerdnetworks.org>
No description provided.