ARROW-7288: [C++] Replace boost::regex with re2 in Parquet #9332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealrichardson
commented
Jan 26, 2021
| @@ -20,13 +20,7 @@ | |||
| #include "arrow/util/windows_compatibility.h" | |||
|
|
|||
| #include <cstdint> | |||
| // Check if thrift version < 0.11.0 | |||
There was a problem hiding this comment.
We now require thrift >= 0.11, so this isn't relevant anymore.
This was referenced Jan 26, 2021
|
Closing in favor of #9367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started on this and think I got the cmake bits worked out, but since re2 doesn't look like a drop-in replacement for std::regex, I think there's more C++ refactoring required, which I don't feel competent enough to take on.