ARROW-11448: [C++] Fix tdigest build failure on Windows with Visual Studio #9382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
nmcdonnell-kx
changed the title
nmcdonnell-kx
changed the title
nmcdonnell-kx
changed the title
nmcdonnell-kx
added a commit
to KxSystems/arrowkdb
that referenced
this pull request
Jan 31, 2021
Reverted to apache-arrow-2.0.0 Opened JIRA: https://issues.apache.org/jira/browse/ARROW-11448 Created PR with fix: apache/arrow#9382
cyb70289
reviewed
Feb 1, 2021
| @@ -21,6 +21,7 @@ | |||
| #include <cmath> | |||
| #include <iostream> | |||
| #include <queue> | |||
| #include <tuple> | |||
There was a problem hiding this comment.
Thanks for fixing it.
It's strange why CI doesn't find this error when I uploaded the original patch.
There was a problem hiding this comment.
Maybe, -DCMAKE_UNITY_BUILD=ON hides this problem.
kou
changed the title
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…tudio CMake args (run from Visual Studio command prompt): ``` C:\Git\arrow3.0.0\cpp\build>cmake .. -DARROW_PARQUET=ON -DARROW_WITH_SNAPPY=ON -DARROW_BUILD_STATIC=OFF -DSnappy_LIB=%SNAPPY_INSTALL%\lib\snappy.lib -DSnappy_INCLUDE_DIR=%SNAPPY_INSTALL%\include -DCMAKE_INSTALL_PREFIX=%BUILD_HOME% ``` Missing `include <tuple>`: ``` 24>C:\Git\arrow3.0.0\cpp\src\arrow\util\tdigest.cc(224,12): error C2039: 'tie': is not a member of 'std' 24>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29333\include\queue(22): message : see declaration of 'std' 24>C:\Git\arrow3.0.0\cpp\src\arrow\util\tdigest.cc(224,1): error C3861: 'tie': identifier not found 24>C:\Git\arrow3.0.0\cpp\src\arrow\util\tdigest.cc(233,12): error C2039: 'tie': is not a member of 'std' 24>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29333\include\queue(22): message : see declaration of 'std' 24>C:\Git\arrow3.0.0\cpp\src\arrow\util\tdigest.cc(233,1): error C3861: 'tie': identifier not found ``` Arrow version: ``` C:\Git\arrow3.0.0\cpp\build>git describe apache-arrow-3.0.0-94-g51e911892 ``` Closes apache#9382 from nmcdonnell-kx/master Authored-by: nmcdonnell-kx <nmcdonnell@kx.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
…tudio CMake args (run from Visual Studio command prompt): ``` C:\Git\arrow3.0.0\cpp\build>cmake .. -DARROW_PARQUET=ON -DARROW_WITH_SNAPPY=ON -DARROW_BUILD_STATIC=OFF -DSnappy_LIB=%SNAPPY_INSTALL%\lib\snappy.lib -DSnappy_INCLUDE_DIR=%SNAPPY_INSTALL%\include -DCMAKE_INSTALL_PREFIX=%BUILD_HOME% ``` Missing `include <tuple>`: ``` 24>C:\Git\arrow3.0.0\cpp\src\arrow\util\tdigest.cc(224,12): error C2039: 'tie': is not a member of 'std' 24>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29333\include\queue(22): message : see declaration of 'std' 24>C:\Git\arrow3.0.0\cpp\src\arrow\util\tdigest.cc(224,1): error C3861: 'tie': identifier not found 24>C:\Git\arrow3.0.0\cpp\src\arrow\util\tdigest.cc(233,12): error C2039: 'tie': is not a member of 'std' 24>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29333\include\queue(22): message : see declaration of 'std' 24>C:\Git\arrow3.0.0\cpp\src\arrow\util\tdigest.cc(233,1): error C3861: 'tie': identifier not found ``` Arrow version: ``` C:\Git\arrow3.0.0\cpp\build>git describe apache-arrow-3.0.0-94-g51e911892 ``` Closes apache#9382 from nmcdonnell-kx/master Authored-by: nmcdonnell-kx <nmcdonnell@kx.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake args (run from Visual Studio command prompt):
Missing
include <tuple>:Arrow version: