ARROW-11483: [C++] Write integration JSON files compatible with the Java reader #9405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ava reader The Java reader for integration files uses an inflexible parsing technique where an empty "children" member in record batches is forbidden. It's probably easier to make the C++ side produce compatible files, rather than fix the Java parser to be more tolerant. Also, fix an issue where data values of null entries in numeric arrays were quoted.
emkornfield
approved these changes
Feb 6, 2021
|
+1 thanks. |
1 similar comment
|
+1 thanks. |
nevi-me
pushed a commit
to nevi-me/arrow
that referenced
this pull request
Feb 13, 2021
…ava reader The Java reader for JSON integration files uses an inflexible parsing technique where an empty "children" member in record batches is forbidden. It's probably easier to make the C++ side produce compatible files, rather than fix the Java parser to be more tolerant. Also, fix an issue where data values of null entries in numeric arrays were quoted. Closes apache#9405 from pitrou/ARROW-11483-write-java-compatible-json Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…ava reader The Java reader for JSON integration files uses an inflexible parsing technique where an empty "children" member in record batches is forbidden. It's probably easier to make the C++ side produce compatible files, rather than fix the Java parser to be more tolerant. Also, fix an issue where data values of null entries in numeric arrays were quoted. Closes apache#9405 from pitrou/ARROW-11483-write-java-compatible-json Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
…ava reader The Java reader for JSON integration files uses an inflexible parsing technique where an empty "children" member in record batches is forbidden. It's probably easier to make the C++ side produce compatible files, rather than fix the Java parser to be more tolerant. Also, fix an issue where data values of null entries in numeric arrays were quoted. Closes apache#9405 from pitrou/ARROW-11483-write-java-compatible-json Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java reader for JSON integration files uses an inflexible parsing technique where an empty "children" member in record batches is forbidden.
It's probably easier to make the C++ side produce compatible files, rather than fix the Java parser to be more tolerant.
Also, fix an issue where data values of null entries in numeric arrays were quoted.