Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-12138: [Go][IPC] Update flatbuffers definitions #9836

Closed
wants to merge 1 commit into from

Conversation

zeroshade
Copy link
Member

Updating the generated flatbuffer code so that newer features like compression in IPC can get implemented. Doing the updating of the flatbuffer generated code first as a separate change.

@sbinet @emkornfield

@zeroshade
Copy link
Member Author

All that was done for this change was to run go run ./gen-flatbuffers.go followed by updating the couple of files in the ipc module which had to switch direct references to byte or int16 to the exported types from the flatbuffers files. So the only files in this change that contain anything that wasn't generated by flatc are ipc/file_writer.go, ipc/message.go and ipc/metadata.go. Everything else just contains the generated flatbuffer code.

@github-actions
Copy link

@zeroshade
Copy link
Member Author

@sbinet @emkornfield @wesm once this is merged, i have a PR ready for adding compression handling to the go IPC implementation, I'm just waiting for this to get merged before filing it for ease of review

emkornfield pushed a commit that referenced this pull request Apr 7, 2021
This is my follow up from #9836

Closes #9862 from zeroshade/ipc/compression

Authored-by: Matthew Topol <mtopol@factset.com>
Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
Updating the generated flatbuffer code so that newer features like compression in IPC can get implemented. Doing the updating of the flatbuffer generated code first as a separate change.

@sbinet @emkornfield

Closes apache#9836 from zeroshade/arrow-12138

Authored-by: Matthew Topol <mtopol@factset.com>
Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
This is my follow up from apache#9836

Closes apache#9862 from zeroshade/ipc/compression

Authored-by: Matthew Topol <mtopol@factset.com>
Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 10, 2021
Updating the generated flatbuffer code so that newer features like compression in IPC can get implemented. Doing the updating of the flatbuffer generated code first as a separate change.

@sbinet @emkornfield

Closes apache#9836 from zeroshade/arrow-12138

Authored-by: Matthew Topol <mtopol@factset.com>
Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 10, 2021
This is my follow up from apache#9836

Closes apache#9862 from zeroshade/ipc/compression

Authored-by: Matthew Topol <mtopol@factset.com>
Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 13, 2021
Updating the generated flatbuffer code so that newer features like compression in IPC can get implemented. Doing the updating of the flatbuffer generated code first as a separate change.

@sbinet @emkornfield

Closes apache#9836 from zeroshade/arrow-12138

Authored-by: Matthew Topol <mtopol@factset.com>
Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 13, 2021
This is my follow up from apache#9836

Closes apache#9862 from zeroshade/ipc/compression

Authored-by: Matthew Topol <mtopol@factset.com>
Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
@zeroshade zeroshade deleted the arrow-12138 branch September 12, 2021 19:34
@asfimport asfimport mentioned this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants