ARROW-12205: [C++][Gandiva] Implement TO_TIME([number] seconds) and TO_TIMESTAMP([number] seconds) function #9890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projjal
suggested changes
Apr 8, 2021
jpedroantunes
changed the title
jpedroantunes
force-pushed
the
feature/to-timestamp-function
branch
from
f2670ea
to
24754db
Compare
jpedroantunes
changed the title
jpedroantunes
force-pushed
the
feature/to-timestamp-function
branch
4 times, most recently
from
521ad94
to
d0934f1
Compare
jpedroantunes
force-pushed
the
feature/to-timestamp-function
branch
6 times, most recently
from
8748bec
to
636b283
Compare
projjal
reviewed
Apr 29, 2021
jpedroantunes
force-pushed
the
feature/to-timestamp-function
branch
2 times, most recently
from
fcc1321
to
8982a6f
Compare
projjal
reviewed
Apr 30, 2021
jpedroantunes
force-pushed
the
feature/to-timestamp-function
branch
from
8982a6f
to
ae0640e
Compare
projjal
reviewed
Apr 30, 2021
projjal
reviewed
May 2, 2021
jpedroantunes
force-pushed
the
feature/to-timestamp-function
branch
from
b8d0d0f
to
6b26ab4
Compare
jvictorhuguenin
force-pushed
the
feature/to-timestamp-function
branch
from
3bb0d89
to
0eb7289
Compare
projjal
approved these changes
May 6, 2021
jvictorhuguenin
force-pushed
the
feature/to-timestamp-function
branch
from
77d12c6
to
5d277a3
Compare
jpedroantunes
force-pushed
the
feature/to-timestamp-function
branch
from
cf9bd3d
to
31fdbd2
Compare
projjal
approved these changes
May 20, 2021
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
…O_TIMESTAMP([number] seconds) function ImpleImplement TO_TIME([number] seconds) and TO_TIMESTAMP([number] seconds) function Closes apache#9890 from jpedroantunes/feature/to-timestamp-function and squashes the following commits: 315a6db <Anthony Louis> Change return type of to_time functions 31fdbd2 <João Pedro> Correct values used on to time test ec3919f <João Pedro Antunes Ferreira> Correct comments on to_time test 7421142 <João Pedro> Apply corrections on to time tests to try to handle floating points 0df0a3b <João Pedro> Define input timestamp comments 805a2d9 <João Pedro> Apply corrections on to time tests to handle floating points 93f8ec5 <João Pedro> Correct dev lint options 4999fd5 <João Pedro> Correct dev lint options f117af6 <João Pedro> Add necessary static casts on tests a6a396e <João Pedro> Add case tests for to_timestamp with fractional parts de64aae <João Pedro> Add case tests for to_timestamp with fractional parts de93dc2 <João Pedro> Fix to time implementation to get the time of the day b44aea0 <João Pedro> Fix local lint errors 2013d44 <João Pedro> Fix to time function to consider seconds as input 3af0718 <João Pedro> Change to time implementation to handle secs and not millis b5c6ca1 <João Pedro> Fix lint problems on time.cc file f904a3b <João Pedro> Fix tests for timestamp and time to not need casting f090220 <João Pedro> Add tests for to timestamp function bf81503 <João Pedro> Add to_time definition for numeric types d9119ee <João Pedro> Change definition of to_timestamp function to work for numeric types 33230ca <João Pedro> Remove unused function on time.cc b41c3c2 <João Pedro> Add function registry for to_timestamp method b5a80ed <João Pedro> Add unit tests for to_timestamp method d26179e <João Pedro> Add base declaration for to_timestamp for numeric in gandiva types.h d19f3f6 <João Pedro> Add base implementation for to_timestamp for numeric in gandiva Lead-authored-by: João Pedro <joaop@simbioseventures.com> Co-authored-by: João Pedro Antunes Ferreira <42006402+jpedroantunes@users.noreply.github.com> Co-authored-by: Anthony Louis <anthony@simbioseventures.com> Signed-off-by: Praveen <praveen@dremio.com>
jvictorhuguenin
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Sep 21, 2021
…O_TIMESTAMP([number] seconds) function ImpleImplement TO_TIME([number] seconds) and TO_TIMESTAMP([number] seconds) function Closes apache#9890 from jpedroantunes/feature/to-timestamp-function and squashes the following commits: 315a6db <Anthony Louis> Change return type of to_time functions 31fdbd2 <João Pedro> Correct values used on to time test ec3919f <João Pedro Antunes Ferreira> Correct comments on to_time test 7421142 <João Pedro> Apply corrections on to time tests to try to handle floating points 0df0a3b <João Pedro> Define input timestamp comments 805a2d9 <João Pedro> Apply corrections on to time tests to handle floating points 93f8ec5 <João Pedro> Correct dev lint options 4999fd5 <João Pedro> Correct dev lint options f117af6 <João Pedro> Add necessary static casts on tests a6a396e <João Pedro> Add case tests for to_timestamp with fractional parts de64aae <João Pedro> Add case tests for to_timestamp with fractional parts de93dc2 <João Pedro> Fix to time implementation to get the time of the day b44aea0 <João Pedro> Fix local lint errors 2013d44 <João Pedro> Fix to time function to consider seconds as input 3af0718 <João Pedro> Change to time implementation to handle secs and not millis b5c6ca1 <João Pedro> Fix lint problems on time.cc file f904a3b <João Pedro> Fix tests for timestamp and time to not need casting f090220 <João Pedro> Add tests for to timestamp function bf81503 <João Pedro> Add to_time definition for numeric types d9119ee <João Pedro> Change definition of to_timestamp function to work for numeric types 33230ca <João Pedro> Remove unused function on time.cc b41c3c2 <João Pedro> Add function registry for to_timestamp method b5a80ed <João Pedro> Add unit tests for to_timestamp method d26179e <João Pedro> Add base declaration for to_timestamp for numeric in gandiva types.h d19f3f6 <João Pedro> Add base implementation for to_timestamp for numeric in gandiva Lead-authored-by: João Pedro <joaop@simbioseventures.com> Co-authored-by: João Pedro Antunes Ferreira <42006402+jpedroantunes@users.noreply.github.com> Co-authored-by: Anthony Louis <anthony@simbioseventures.com> Signed-off-by: Praveen <praveen@dremio.com> (cherry picked from commit f1a7b0d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImpleImplement TO_TIME([number] seconds) and TO_TIMESTAMP([number] seconds) function