ARROW-12325: [C++] [CI] Nightly gandiva build failing due to failure of compiler to move return value #9975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe add a comment to this effect so that whenever we remove support for gcc < 4.9, we can remove this? Or could you even use an |
|
I agree, an ifdef could be OK, though right now this is only used in tests. This builds/passes tests: https://github.com/lidavidm/crossbow/actions/runs/748817979 (it fails on uploading but we don't care about that). |
cyb70289
reviewed
Apr 16, 2021
|
ifdef looks more clear to show our intention. |
cyb70289
requested changes
Apr 18, 2021
…urn local variables if the output type does not match exactly the return type.
westonpace
force-pushed
the
bugfix/ARROW-12325
branch
from
926c3a8
to
c59eb73
Compare
|
Can we merge this to include this into 4.0.0 RC2? |
|
The build failures appear to all be expected. MacOS is failing due to LLVM (ARROW-12467). C GLib & Ruby is failing on Windows with segmentation fault but was doing so before this (we should probably create a JIRA). The JNI failure is ARROW-11633 |
cyb70289
approved these changes
Apr 21, 2021
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…of compiler to move return value Gandiva build failure caused by failure of GCC 4.8.2 compiler to automatically move return value. Failed build: https://github.com/ursacomputing/crossbow/runs/2303374510 Godbolt showing I'm not crazy: https://gcc.godbolt.org/z/x138zevhE Closes apache#9975 from westonpace/bugfix/ARROW-12325 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Yibo Cai <yibo.cai@arm.com>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 10, 2021
…of compiler to move return value Gandiva build failure caused by failure of GCC 4.8.2 compiler to automatically move return value. Failed build: https://github.com/ursacomputing/crossbow/runs/2303374510 Godbolt showing I'm not crazy: https://gcc.godbolt.org/z/x138zevhE Closes apache#9975 from westonpace/bugfix/ARROW-12325 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Yibo Cai <yibo.cai@arm.com>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
…of compiler to move return value Gandiva build failure caused by failure of GCC 4.8.2 compiler to automatically move return value. Failed build: https://github.com/ursacomputing/crossbow/runs/2303374510 Godbolt showing I'm not crazy: https://gcc.godbolt.org/z/x138zevhE Closes apache#9975 from westonpace/bugfix/ARROW-12325 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Yibo Cai <yibo.cai@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gandiva build failure caused by failure of GCC 4.8.2 compiler to automatically move return value.
Failed build: https://github.com/ursacomputing/crossbow/runs/2303374510
Godbolt showing I'm not crazy: https://gcc.godbolt.org/z/x138zevhE