ATLAS-4318 : fix python client api url concatenation #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for the PR |
nixonrodrigues
changed the title
asfgit
pushed a commit
that referenced
this pull request
Jun 1, 2021
(cherry picked from commit 4f74de1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the python client api endpoints are currently broken as the result of the concatenation of the base url with the relative context path items.
Specifically this happens for those path which contain a trailing forward slash (
/), e.g.This produced requests of the kind:
which obviously resulted in errors.
Instead of simply removing the
/from the base paths I've chosen the approach of replacing the url concatenation method with a more robust one that handles leading and trailing slashes transparently.I did not find any tests for this module. If I'm wrong please let me know and I'll add/modify them.
Regards!