This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
[BAHIR-315] Move SSL config to FlinkJedisConfigBase #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to support SSL connections in non-cluster configurations. JedisSentinelPool currently doesn't support SSL connections.
|
Let me know if this can be considered part of https://issues.apache.org/jira/browse/BAHIR-315 or if should create a separate ticket. |
|
Checking in on this again since it's been a few weeks now, @eskabetxe. I'm interested in working with the community to land this PR and see this in a release soon 🙏 |
eskabetxe
changed the title
|
Hi @srmrz , |
|
@eskabetxe thanks for merging this a while back. We're hoping to use Apache Bahir in production but we haven't seen this change land in a new release yet. Do you know when we should expect to see a new release of this project? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use the recently added support for SSL (#155), we realized that we needed support for non-cluster mode.
Here we add support for SSL connections in non-cluster configurations.
Two things:
ssltouseSsl. But I'm very happy to change that back tosslif there's pushback.