Skip to content
This repository has been archived by the owner on Feb 16, 2024. It is now read-only.

[MINOR] update ImportOrderChecker #30

Closed
wants to merge 5 commits into from

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Jan 6, 2017

Proposed change

org.apache.bahir.* import statements should not be mixed in group of 3rd-party imports but instead should be grouped together in last group of imports (after group of org.apache.spark.* imports which should remain a separate group)

How was this change tested?

full test build mvn clean install test

@akchinSTC
Copy link

Build finished.

@ckadner
Copy link
Member Author

ckadner commented Jan 9, 2017

retest this please

@akchinSTC
Copy link

Build finished.

@akchinSTC
Copy link

Refer to this link for build results (access rights to CI server needed):
/job/Apache%20Bahir%20-%20Pull%20Request%20Builder/13/

@ckadner
Copy link
Member Author

ckadner commented Jan 9, 2017

Test this Jenkins

@akchinSTC
Copy link

Build finished.

@akchinSTC
Copy link

Refer to this link for build results (access rights to CI server needed):
http://169.45.79.58:8080/job/Apache%20Bahir%20-%20Pull%20Request%20Builder/14/

@ckadner
Copy link
Member Author

ckadner commented Jan 9, 2017

ok to test

@ApacheBahir
Copy link

Build finished.

@ApacheBahir
Copy link

Refer to this link for build results (access rights to CI server needed):
http://169.45.79.58:8080/job/Apache%20Bahir%20-%20Pull%20Request%20Builder/15/

@ckadner
Copy link
Member Author

ckadner commented Jan 9, 2017

retest this please

@ApacheBahir
Copy link

Build finished.

@ApacheBahir
Copy link

Refer to this link for build results (access rights to CI server needed):
http://169.45.79.58:8080/job/Apache%20Bahir%20-%20Pull%20Request%20Builder/17/

@ApacheBahir
Copy link

Build finished.

@ApacheBahir
Copy link

Refer to this link for build results (access rights to CI server needed):
http://169.45.79.58:8080/job/Apache%20Bahir%20-%20Pull%20Request%20Builder/18/

@ckadner
Copy link
Member Author

ckadner commented Jan 9, 2017

retest this please

@ApacheBahir
Copy link

Build finished.

@ApacheBahir
Copy link

Refer to this link for build results (access rights to CI server needed):
http://169.45.79.58:8080/job/Apache%20Bahir%20-%20Pull%20Request%20Builder/19/

@ApacheBahir
Copy link

Build finished.

@ApacheBahir
Copy link

Refer to this link for build results (access rights to CI server needed):
http://169.45.79.58:8080/job/Apache%20Bahir%20-%20Pull%20Request%20Builder/20/

@ckadner
Copy link
Member Author

ckadner commented Jan 9, 2017

retest this please

@ApacheBahir
Copy link

Build triggered. sha1 is merged.

@ApacheBahir
Copy link

Build started sha1 is merged.

@ApacheBahir
Copy link

Build successful

@ApacheBahir
Copy link

Refer to this link for build results (access rights to CI server needed):
http://169.45.79.58:8080/job/Apache%20Bahir%20-%20Pull%20Request%20Builder/24/

@ckadner
Copy link
Member Author

ckadner commented Jan 9, 2017

retest this please

@ApacheBahir
Copy link

Build succeeded

@ApacheBahir
Copy link

Refer to this link for build results (access rights to CI server needed):
http://169.45.79.58:8080/job/Apache%20Bahir%20-%20Pull%20Request%20Builder/25/

@ApacheBahir
Copy link

Build failed, see build log for details

@ApacheBahir
Copy link

Refer to this link for build results (access rights to CI server needed):
http://169.45.79.58:8080/job/Apache%20Bahir%20-%20Pull%20Request%20Builder/26/

@ApacheBahir
Copy link

Build successful

@ApacheBahir
Copy link

Refer to this link for build results (access rights to CI server needed):
http://169.45.79.58:8080/job/Apache%20Bahir%20-%20Pull%20Request%20Builder/27/

@ckadner
Copy link
Member Author

ckadner commented Jan 10, 2017

trying to produce test result logs

retest this please

@ApacheBahir
Copy link

Build successful

@ApacheBahir
Copy link

Refer to this link for build results (access rights to CI server needed):
http://169.45.79.58:8080/job/Apache%20Bahir%20-%20Pull%20Request%20Builder/28/

@lresende
Copy link
Member

Changes LGTM
Could you please use a shorter and more readable pr title.

@ckadner ckadner changed the title [MINOR] scalastyle:ImportOrderChecker - add group for org.apache.bahir.* [MINOR] update ImportOrderChecker Jan 18, 2017
@asfgit asfgit closed this in 560a799 Jan 19, 2017
@ckadner ckadner deleted the scalastyle-fixes branch January 19, 2017 22:58
@ckadner
Copy link
Member Author

ckadner commented Mar 28, 2017

retest this please

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants