Skip to content
This repository has been archived by the owner on Feb 16, 2024. It is now read-only.

[BAHIR-182] Spark Streaming PubNub connector #70

Closed
wants to merge 3 commits into from

Conversation

lukasz-antoniak
Copy link
Member

@lresende
Copy link
Member

@lukasz-antoniak Could you please add a readme.md that documents the new extension which is used to generate the extension documentation on the website.

Copy link
Member

@lresende lresende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks ok, but we need to have a readme.md with the proper extension documentation that is used to generate the extension docs on the website.

@lukasz-antoniak
Copy link
Member Author

Thank you for quick verification. I have created module README and updated README from project root directory to correctly reference all modules in alphabetical order.

@lresende
Copy link
Member

lresende commented Nov 30, 2018

@lukasz-antoniak LGTM.

As for the build failure, I did run it successfully on my local machine with the Oracle JDK..., could you please force a new build to make sure all things run ok on Travis CI as well...

@asfgit asfgit closed this in 9373fa4 Nov 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants