Skip to content

Commit

Permalink
[BEAM-3738] Add more flake8 tests to run_pylint.sh
Browse files Browse the repository at this point in the history
  • Loading branch information
cclauss committed Mar 17, 2018
1 parent 6656a90 commit 37432ac
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion sdks/python/run_mini_py3lint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,5 @@ if test $# -gt 0; then
fi

echo "Running flake8 for module $MODULE:"
flake8 $MODULE --count --select=E901,E999,F822,F823 --show-source --statistics
# TODO: Add F821 (undefined names) as soon as that test passes
flake8 $MODULE --count --select=E9,F822,F823 --show-source --statistics
3 changes: 2 additions & 1 deletion sdks/python/run_pylint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ pylint -j8 "$MODULE" --ignore-patterns="$FILES_TO_IGNORE"
echo "Running pycodestyle for module $MODULE:"
pycodestyle "$MODULE" --exclude="$FILES_TO_IGNORE"
echo "Running flake8 for module $MODULE:"
flake8 $MODULE --count --select=E901,E999,F822,F823 --show-source --statistics
# TODO: Add F821 (undefined names) as soon as that test passes
flake8 $MODULE --count --select=E9,F822,F823 --show-source --statistics

echo "Running isort for module $MODULE:"
# Skip files where isort is behaving weirdly
Expand Down

0 comments on commit 37432ac

Please sign in to comment.