-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Go protobuf package to new version #21515
Comments
.take-issue |
I am now working on this. Thanks. |
@lostluck or @damondouglas could one of you please take a look and see if you can help here? |
I'll take a look! Thank you very much! |
The PR is pretty great as is TBH! So the clarify the goal of this issue: The intent is that most of beam isn't relying on the deprecated package to function. So the changes you've made a great thus far. However, we do want to ensure that if users are somehow still relying on v1 protocol buffer types that they're using, that they continue to function. This means we need to keep the code in beam/create_test.go and the protov1 handling code in beam/coder.go with some very small changes. I'll add comments to the PR directly. |
Thank you for the comments. I was going in a different direction. Your clarifications saved me a lot of time! |
The original Go protobuf package (github.com/golang/protobuf/proto) is deprecated and should be replaced with the new version (google.golang.org/protobuf/proto)
Imported from Jira BEAM-14242. Original Jira may contain additional context.
Reported by: jrmccluskey.
Subtask of issue #21513
The text was updated successfully, but these errors were encountered: