Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8587] TestStream for Dataflow runner #10041

Merged
merged 4 commits into from Nov 11, 2019
Merged

Conversation

@acrites
Copy link
Contributor

acrites commented Nov 8, 2019

Adds TestStream support for the DataflowRunner by converting the TestStream PTransform into a TestStreamPayload that is then handled by a corresponding read operation.

I also fixed a few lint errors in nearby code and fixed TestStream's coder, which was set to the class and not an instance of the class (it looks like no other code is actually using this coder, so that's why it wasn't detected).

R: @lukecwik


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

acrites added 3 commits Nov 7, 2019
…n' when running other tests. Moves bad copy of internal/names.py to dataflow/internal/names.py, where it was supposed to go.
@lukecwik

This comment has been minimized.

Copy link
Member

lukecwik commented Nov 8, 2019

Please also fix the lint issues, note that you can run the linter locally ./gradlew :sdks:python:test-suites:tox:py37:lintPy37 from where you checked out the beam git repo.

… nosetest from trying to run the method.
@lukecwik lukecwik merged commit b951993 into apache:master Nov 11, 2019
5 checks passed
5 checks passed
Portable_Python ("Run Portable_Python PreCommit") SUCCESS
Details
Python ("Run Python PreCommit") SUCCESS
Details
Python2_PVR_Flink ("Run Python2_PVR_Flink PreCommit") SUCCESS
Details
PythonLint ("Run PythonLint PreCommit") SUCCESS
Details
RAT ("Run RAT PreCommit") SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.