[BEAM-8882] Fully populate log messages. #10292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertwb
force-pushed
the
fnapi-logging
branch
4 times, most recently
from
ecaed90
to
586aaf0
Compare
robertwb
force-pushed
the
fnapi-logging
branch
from
586aaf0
to
8b3d259
Compare
lukecwik
approved these changes
Dec 5, 2019
| @@ -1036,7 +1036,7 @@ def create(factory, transform_id, transform_proto, parameter, consumers): | |||
| [WindowedValueCoder(source.default_output_coder())]) | |||
| return factory.augment_oldstyle_op( | |||
| operations.ReadOperation( | |||
| transform_proto.unique_name, | |||
| common.NameContext(transform_proto.unique_name, transform_id), | |||
| spec, | |||
| factory.counter_factory, | |||
| factory.state_sampler), | |||
There was a problem hiding this comment.
(this is the closest to the line that I could comment on)
It seems like the transform id/name context is not being propagated through for the ImpulseReadOperation. Should we do it there for consistency as well.
| def emit(self, record): | ||
| log_entry = beam_fn_api_pb2.LogEntry() | ||
| log_entry.severity = self.LOG_LEVEL_MAP[record.levelno] | ||
| log_entry.severity = self.map_log_level(record.levelno) | ||
| log_entry.message = self.format(record) | ||
| log_entry.thread = record.threadName | ||
| log_entry.log_location = record.module + '.' + record.funcName |
There was a problem hiding this comment.
I'm not sure if it would be more natural to put filename:lineno instead of module.funcname but up to you. I understand that the LogEntry proto description lists Python to be module.funcname but that could be changed. Depends on what is more natural for Python developers.
|
Run Python2_PVR_Flink PreCommit |
|
Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed) |
|
Run Python PreCommit |
1 similar comment
|
Run Python PreCommit |
robertwb
added a commit
to robertwb/incubator-beam
that referenced
this pull request
Dec 9, 2019
11moon11
pushed a commit
to 11moon11/beam
that referenced
this pull request
Dec 12, 2019
udim
added a commit
that referenced
this pull request
Dec 13, 2019
|
FnApiLogRecordHandlerTest.test_exc_info() appears to flake, saw the failure twice today, filed https://issues.apache.org/jira/browse/BEAM-8974. |
dpcollins-google
pushed a commit
to dpcollins-google/beam
that referenced
this pull request
Dec 20, 2019
mxm
added a commit
to lyft/beam
that referenced
this pull request
Mar 31, 2020
This reverts commit 6126a59
mxm
added a commit
to lyft/beam
that referenced
this pull request
Apr 3, 2020
Revert "[BEAM-8944] Change to use single thread in py sdk bundle progress report (apache#10387)" This reverts commit 1edcc10 Revert "[BEAM-8882] Fully populate log messages. (apache#10292)" This reverts commit 6126a59 Revert "[BEAM-8733] Handle the registration request synchronously in the Python SDK harness." This reverts commit 26596c8 Revert "[BEAM-8151] Further cleanup of SDK Workers. (apache#10134)" This reverts commit ae5b653 Revert "Setting all logging on the root logger as before." This reverts commit b870d97 Revert "[BEAM-8661] Moving runners to have per-module logger (apache#10097)" This reverts commit 49d6efd. Revert "[BEAM-8151] Swap to create SdkWorkers on demand when processing jobs" This reverts commit 33cc30e Revert "[BEAM-8151, BEAM-7848] Swap to using a thread pool which is unbounded and shrinks when threads are idle." This reverts commit 1b62310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.