[BEAM-8825] Add limit on number of mutated rows to batching/sorting stages. #10380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a potential OOM when very narrow row mutations are added (ie <5 cells, <100 bytes). The overhead of storing a mutation is significant, so with the default grouping of 5000*1000 cells, potentially many millions of mutated rows can be stored in memory during the grouping phase, leading to an OOM. This change adds a 3rd limit on the grouping - that a maximum of 500 rows per batch (500K rows in the grouping stage).
|
@udim as requested. |
|
Run Java PreCommit |
2 similar comments
|
Run Java PreCommit |
|
Run Java PreCommit |
udim
approved these changes
Dec 16, 2019
|
Will ignore Java_Examples_Dataflow (WindowedWordCountIT) test failure since this is a release branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a potential OOM when very narrow row mutations are added (ie
<5 cells, <100 bytes).
The overhead of storing a mutation is significant, so with the default
grouping of 5000*1000 cells, potentially many millions of mutated rows
can be stored in memory during the grouping phase, leading to an OOM.
This change adds a 3rd limit on the grouping - that a maximum of 500 rows
per batch (500K rows in the grouping stage).
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.