Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8976] Setting all logging on the root logger as before. #10416

Merged
merged 2 commits into from
Dec 19, 2019

Conversation

pabloem
Copy link
Member

@pabloem pabloem commented Dec 18, 2019

This will revert the default logging behavior for 2.18.0 release, and we'll add fixes for it for 2.19.0.

r: @udim, @aaltay


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@pabloem pabloem requested review from aaltay and udim December 18, 2019 19:29
@udim
Copy link
Member

udim commented Dec 18, 2019

I believe you missed one:

$ grep -r 'logging.getLogger(__name__)' apache_beam|wc -l
84
$ grep -r 'logging.getLogger(__name__)' apache_beam | grep -v _LOGGER
apache_beam/io/filesystem.py:logger = logging.getLogger(__name__)

edit: or was that intentional?

Copy link
Member

@udim udim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, except possibly missing a change in filesystem.py (see my comment in conversation).

Also, please add BEAM-8976 to the title (I believe it is a solution for 2.18.0).

@pabloem pabloem changed the title Setting all logging on the root logger as before. [BEAM-8976] Setting all logging on the root logger as before. Dec 18, 2019
@udim
Copy link
Member

udim commented Dec 19, 2019

Only wordcounts are failing in python precommit, as expected. Okay to merge.

@pabloem
Copy link
Member Author

pabloem commented Dec 19, 2019

Thanks Udi. Please merge when you determine it convenient.

@udim udim merged commit 0658bc6 into apache:release-2.18.0 Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants