Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.18.0][BEAM-9123] HadoopResourceId returns wrong directoryName bugfix #10625

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

dmvk
Copy link
Member

@dmvk dmvk commented Jan 17, 2020

@dmvk dmvk requested a review from udim January 17, 2020 13:47
@dmvk
Copy link
Member Author

dmvk commented Jan 17, 2020

cc @aromanenko-dev

@aromanenko-dev aromanenko-dev changed the title [BEAM-9123] HadoopResourceId returns wrong directoryName bugfix [release-2.18.0][BEAM-9123] HadoopResourceId returns wrong directoryName bugfix Jan 17, 2020
Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aromanenko-dev aromanenko-dev merged commit b813ed9 into apache:release-2.18.0 Jan 17, 2020
@tvalentyn
Copy link
Contributor

Please do not merge commits into release branches without an approval from the release manager. This has been discussed on Beam mailing least a few times.

@udim
Copy link
Member

udim commented Jan 21, 2020

Since 2.19 has the same cherrypick, could we make this a known issue for 2.18 and revert this?

@aromanenko-dev
Copy link
Contributor

aromanenko-dev commented Jan 22, 2020

@tvalentyn Sorry for messing things up. I'm fine to revert this commit from release-2.18.0 branch since it's not a blocker. wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants