[BEAM-9490] Guard referencing for environment expiration via a lock #11108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxm
commented
Mar 12, 2020
...ution/src/main/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactory.java
Outdated
Show resolved
Hide resolved
...ution/src/main/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactory.java
Outdated
Show resolved
Hide resolved
mxm
force-pushed
the
BEAM-9490
branch
2 times, most recently
from
d9bf4d7
to
55b3268
Compare
When environment expiration is configured, environments are removed from a cache map after some amount of time. This cache map may be accessed by multiple ExecutableStage transforms in parallel. During environment expiration there is a small time window which allows for an environment to still being used while another transform removes, dereferences, and closes the environment. This is not expected behavior.
|
@tweise Any comments? I've been running this on a cluster for a day with a 15 minute environment expiration. Haven't seen any problems with regards to the environment expiration. |
|
@mxm I'm looking at this and will get back. |
tweise
reviewed
Mar 13, 2020
...ution/src/main/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactory.java
Outdated
Show resolved
Hide resolved
…alancing is enabled
|
Run Python2_PVR_Flink PreCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When environment expiration is configured, environments are removed from a cache
map after some amount of time. This cache map may be accessed by multiple
ExecutableStage transforms in parallel. During environment expiration there is a
small time window which allows for an environment to still being used while
another transform removes, dereferences, and closes the environment. This is not
expected behavior.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.