-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-790] Validate PipelineOptions Default annotation. #1159
Changes from 1 commit
e0dcb2a
3e87aa6
f8b672e
75ccba8
f7b108b
0038aa5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -139,12 +139,12 @@ private interface Options extends PipelineOptions { | |
public void testToStringForPrint() throws Exception { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. testToStringForPrint -> testAnnotationFormatter Add a test for a default value with a . and ( and $ in it so that we remember why we have string parsing logic setup the way we do. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
assertEquals( | ||
"Default.Integer(value=1)", | ||
ReflectHelpers.toStringForPrint( | ||
ReflectHelpers.ANNOTATION_CONCISE_STRING.apply( | ||
Options.class.getMethod("getInteger").getAnnotations()[0])); | ||
|
||
assertEquals( | ||
"JsonIgnore(value=true)", | ||
ReflectHelpers.toStringForPrint( | ||
ReflectHelpers.ANNOTATION_CONCISE_STRING.apply( | ||
Options.class.getMethod("getObject").getAnnotations()[0])); | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ANNOTATION_CONCISE_STRING -> ANNOTATION_FORMATTER
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done