-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-3304] Refactor trigger API #15952
Conversation
Run Go PostCommit |
Looks like the commits from previous work followed. But did merge master at the end. |
func (t *RepeatTrigger) SubTrigger() Trigger { | ||
return t.subTrigger | ||
} | ||
|
||
// Repeat constructs a trigger that fires a trigger repeatedly | ||
// once the condition has been met. | ||
// | ||
// Ex: trigger.Repeat(trigger.AfterCount(1)) is same as trigger.Always(). | ||
func Repeat(tr Trigger) Trigger { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, return *RepeatTrigger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't know the type of trigger set by the user in this case.
Run Go PostCommit |
Run Go PostCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marvelous! Thanks!
Refactor existing trigger API in Go SDK. Converted the
trigger.Trigger
from struct to interface.Thanks @lostluck for all the suggestions!
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.