-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-3304] documentation for PaneInfo in BPG #17047
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17047 +/- ##
=======================================
Coverage 73.75% 73.76%
=======================================
Files 667 667
Lines 87406 87406
=======================================
+ Hits 64468 64473 +5
+ Misses 21831 21826 -5
Partials 1107 1107
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label go. Available commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request as a reviewer - in the future for website changes, could you please link to the rendered website page that you're modifying, or take a screenshot if its a small change? Website_Stage_GCS automatically publishes a version, you can find the link in the CI build (in this case its http://apache-beam-website-pull-requests.storage.googleapis.com/17047/documentation/programming-guide/index.html#other-dofn-parameters). Personally, I like embedding a screenshot in the description even more so there's no link following needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R: @youngoli - looks like the bot still can't authenticate 😢 so requesting final approval didn't work |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
This looks mostly good to me, except I think the changes to Beam itself should go in a separate PR and the website changes should be submitted once the feature is available in a current release (so we should wait a little if this is coming in 2.38). Ritesh, can you create a new PR with just the changes in pkg/beam and test/integration? That one should be a quick review & merge from me. |
The pane observation is available in 2.37.0 but I didn't submit the documentation at that time. So I think this should be good to merge. |
R: @lostluck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update Beam Programming guide to reflect usage of PaneInfo for Go SDK.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.