Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-3304] documentation for PaneInfo in BPG #17047

Merged
merged 2 commits into from
Mar 19, 2022

Conversation

riteshghorse
Copy link
Contributor

@riteshghorse riteshghorse commented Mar 8, 2022

Update Beam Programming guide to reflect usage of PaneInfo for Go SDK.
image


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #17047 (4fc996a) into master (95a5c26) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17047   +/-   ##
=======================================
  Coverage   73.75%   73.76%           
=======================================
  Files         667      667           
  Lines       87406    87406           
=======================================
+ Hits        64468    64473    +5     
+ Misses      21831    21826    -5     
  Partials     1107     1107           
Flag Coverage Δ
go 48.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/forward.go 40.00% <ø> (ø)
.../python/apache_beam/transforms/periodicsequence.py 96.72% <0.00%> (-1.64%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.06% <0.00%> (+0.15%) ⬆️
sdks/python/apache_beam/internal/metrics/metric.py 91.00% <0.00%> (+1.00%) ⬆️
...che_beam/runners/interactive/interactive_runner.py 92.75% <0.00%> (+1.44%) ⬆️
.../python/apache_beam/testing/test_stream_service.py 93.02% <0.00%> (+4.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95a5c26...4fc996a. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request as a reviewer - in the future for website changes, could you please link to the rendered website page that you're modifying, or take a screenshot if its a small change? Website_Stage_GCS automatically publishes a version, you can find the link in the CI build (in this case its http://apache-beam-website-pull-requests.storage.googleapis.com/17047/documentation/programming-guide/index.html#other-dofn-parameters). Personally, I like embedding a screenshot in the description even more so there's no link following needed

@github-actions github-actions bot added examples and removed examples labels Mar 9, 2022
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

image

@damccorm
Copy link
Contributor

damccorm commented Mar 9, 2022

R: @youngoli - looks like the bot still can't authenticate 😢 so requesting final approval didn't work

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@youngoli
Copy link
Contributor

This looks mostly good to me, except I think the changes to Beam itself should go in a separate PR and the website changes should be submitted once the feature is available in a current release (so we should wait a little if this is coming in 2.38).

Ritesh, can you create a new PR with just the changes in pkg/beam and test/integration? That one should be a quick review & merge from me.

@riteshghorse
Copy link
Contributor Author

riteshghorse commented Mar 18, 2022

The pane observation is available in 2.37.0 but I didn't submit the documentation at that time. So I think this should be good to merge.

@riteshghorse
Copy link
Contributor Author

R: @lostluck

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lostluck lostluck merged commit 06bcd6a into apache:master Mar 19, 2022
@riteshghorse riteshghorse deleted the beam-3304 branch June 1, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants