[WIP] Run com2ann on Python SDK #17109
Conversation
TheNeuralBit
force-pushed
the
com2ann
branch
2 times, most recently
from
4d17d61
to
e2ee9c0
Compare
TheNeuralBit
changed the title
| @@ -782,17 +756,15 @@ def _from_normal_time(self, value): | |||
| """Convert signed to "lexicographically ordered unsigned".""" | |||
| return value + _TIME_SHIFT | |||
|
|
|||
| def encode_to_stream(self, value, out, nested): | |||
| # type: (IntervalWindow, create_OutputStream, bool) -> None | |||
| def encode_to_stream(self, value: IntervalWindow, out: create_OutputStream, nested: bool) -> None: | |||
There was a problem hiding this comment.
The annotation is consistent with the original comment, what looks wrong?
There was a problem hiding this comment.
create_OutputStream is not (necessarily) a type. I think it's possible that the comment was wrong. (Either that or perhaps create_OutputStream should be renamed to OutputStreamType.)
|
I think we'll need to run yapf on the whole codebase to get this in. Would you be ok with that @robertwb? It will likely make a lot of odd formatting decisions that we can't review manually |
|
We already ran yapf on the full codebase, right? Yes, I think we need to bite the bullet and to this. |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Run
com2annon the entire Python SDK, to convert all typehints in comments to annotations.GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.