Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-13657] Follow up update version warning in __init__ #17493

Merged
merged 1 commit into from
May 3, 2022

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Apr 28, 2022

Minor: found a place in code should update along with sunset python 3.6

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Apr 28, 2022

Can one of the admins verify this patch?

2 similar comments
@asf-ci
Copy link

asf-ci commented Apr 28, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Apr 28, 2022

Can one of the admins verify this patch?

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #17493 (bc6a3ba) into master (67cb419) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #17493   +/-   ##
=======================================
  Coverage   73.83%   73.83%           
=======================================
  Files         690      690           
  Lines       90830    90830           
=======================================
+ Hits        67064    67068    +4     
+ Misses      22557    22553    -4     
  Partials     1209     1209           
Flag Coverage Δ
python 83.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/__init__.py 85.00% <100.00%> (ø)
sdks/python/apache_beam/utils/interactive_utils.py 92.68% <0.00%> (-2.44%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 93.08% <0.00%> (+0.64%) ⬆️
sdks/python/apache_beam/internal/metrics/metric.py 93.00% <0.00%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67cb419...bc6a3ba. Read the comment docs.

@Abacn
Copy link
Contributor Author

Abacn commented Apr 28, 2022

R: @AnandInguva

@AnandInguva
Copy link
Contributor

LGTM! Thanks for catching this

@AnandInguva
Copy link
Contributor

cc : @tvalentyn

@tvalentyn tvalentyn merged commit 82e13d5 into apache:master May 3, 2022
@Abacn Abacn deleted the beam-13659followup branch May 3, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants