-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-14347] Add generic registration for Combiners #17579
[BEAM-14347] Add generic registration for Combiners #17579
Conversation
Can one of the admins verify this patch? |
3 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #17579 +/- ##
==========================================
- Coverage 73.95% 73.95% -0.01%
==========================================
Files 693 693
Lines 91716 91690 -26
==========================================
- Hits 67832 67812 -20
+ Misses 22635 22629 -6
Partials 1249 1249
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
R: @lostluck Since this one has a bunch of generic + generated code and is a tougher one to review without context, I'm going to send this directly to you |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming aside: LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge once the conflict from the emitters/iters is resolved.
Done |
This is a continuation of the work started in #17429 and #17574 and extends the existing registration logic to allow registration of combiners.
Design doc: https://docs.google.com/document/d/1MLZLUhb-Sn7AJ666yn3TnYgMKE6wiXIBs7cjB_20hMA/edit?usp=sharing
After this, the big remaining chunks of work are:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.