Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14429] Fix SyntheticUnboundedSource data duplication with SDF wrapper #17600

Merged
merged 1 commit into from
May 10, 2022

Conversation

y1chi
Copy link
Contributor

@y1chi y1chi commented May 10, 2022

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@y1chi
Copy link
Contributor Author

y1chi commented May 10, 2022

R: @chamikaramj

@y1chi
Copy link
Contributor Author

y1chi commented May 10, 2022

R: @lukecwik

@chamikaramj
Copy link
Contributor

chamikaramj commented May 10, 2022

Thanks. LGTM.

May be fix the wording of the following log as well (it logs splits not sizes of splits).

LOG.info("Split into {} bundles of sizes: {}", splits.size(), splits);

@y1chi
Copy link
Contributor Author

y1chi commented May 10, 2022

Run Kotlin_Examples PreCommit

@y1chi
Copy link
Contributor Author

y1chi commented May 10, 2022

Run Java PreCommit

@y1chi y1chi changed the title [BEAM-14229] Fix logging by override SyntheticUnboundedSource toString [BEAM-14229] Fix SyntheticUnboundedSource data duplication with SDF wrapper May 10, 2022
@y1chi y1chi changed the title [BEAM-14229] Fix SyntheticUnboundedSource data duplication with SDF wrapper [BEAM-14429] Fix SyntheticUnboundedSource data duplication with SDF wrapper May 10, 2022
Copy link
Member

@lukecwik lukecwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure that this change won't break the update compatibility tests or change the encoding to be current+end instead of start+end

@chamikaramj
Copy link
Contributor

Thanks. LGTM.

@y1chi
Copy link
Contributor Author

y1chi commented May 10, 2022

Just make sure that this change won't break the update compatibility tests or change the encoding to be current+end instead of start+end

I believe update compatibility test pipeline doesn't involve this source directly.

@lukecwik
Copy link
Member

Just make sure that this change won't break the update compatibility tests or change the encoding to be current+end instead of start+end

I believe update compatibility test pipeline doesn't involve this source directly.

Great.

Copy link
Member

@lukecwik lukecwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a test that shows the incorrect behavior is fixed?

Merging as is for the fix.

@lukecwik lukecwik merged commit c632276 into apache:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants