[BEAM-14464] More efficient grouping keys in precombiner table. #17641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owedValueCoder. The latter skips a whole bunch of checks to generate the correctly specialized WindowedValue type, especially for elements in the global window.
The current code constructs, hashes, and compares full WindowedValues for the grouping key, which ends up dominating the time spent in the combining table when using trivial combiners (like Sum.integers()). We only need compare the (structural value of the) key and windows, and can emit the windows in the global case. Per added microbenchmarks, this is roughly a 50% improvement for singly-windowed values, and roughly 2.5x improvement for the common GlobalWindows case.
|
R: @y1chi |
|
I have been looking for someone to review #17327, do you mind if we get that merged first and then take on this change? |
|
Thanks, Yichi! As mentioned, I'm going to hold off merging this until that other PR goes in. |
4 tasks
|
The other PR is merged. Could this be merged? |
|
Failures org.apache.beam.sdk.io.aws2.kinesis.KinesisIOWriteTest.testWriteFailure look unrelated. |
|
Run Java PreCommit |
|
precommit is broken again due to checkStyle warnings |
4 tasks
|
Sure, we can hold off on this until that is in to avoid conflicts.
…On Thu, May 12, 2022 at 12:02 PM Lukasz Cwik ***@***.***> wrote:
I have been looking for someone to review #17327, do you mind if we get that merged first and then take on this change?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code constructs, hashes, and compares full WindowedValues
for the grouping key, which ends up dominating the time spent in the
combining table when using trivial combiners (like Sum.integers()).
We only need compare the (structural value of the) key and windows,
and can emit the windows in the global case.
Per added microbenchmarks, this is roughly a 50% improvement for
singly-windowed values, and roughly 2.5x improvement for the common
GlobalWindows case.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.