[BEAM-1762] Make error message python 3.6 compatible #2275
Conversation
|
I think the JIRA ticket referred to in this PR's title is the wrong one. |
jrmlhermitte
changed the title
|
@aviemzur thank you |
|
R: @tibkiss |
|
Nice catch -- I was not aware of the deprecation of the old string formatting. I only see one problem with 'str.format': It is only supported from 2.6 onwards. |
|
that's a good idea, thanks for the feedback. I added it. |
|
LGTM. Thanks for the fix, @ordirules! |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Jenkins: retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
sdks/python/apache_beam/__init__.py
Outdated
| @@ -69,7 +69,7 @@ | |||
| if not (sys.version_info[0] == 2 and sys.version_info[1] == 7): | |||
| raise RuntimeError( | |||
| 'Dataflow SDK for Python is supported only on Python 2.7. ' | |||
| 'It is not supported on Python [%s].' % sys.version_info) | |||
| 'It is not supported on Python '+ str(sys.version_info) + '.') | |||
There was a problem hiding this comment.
Do you want to put [] around the version or remove the . at the end to avoid confusion?
There was a problem hiding this comment.
oops yes I accidentally remove those. changed, thanks!
|
Refer to this link for build results (access rights to CI server needed): |
|
LGTM. Thank you @ordirules |
|
@aaltay no problem. |
|
@ordirules : Sorry for coming back on your question delayed. There are multiple JIRAs open regarding 2 to 3 conversion: As @chamikaramj points out in BEAM-1373 it is not a trivial task due to the string array / unicode conversion. I'd also like to mention that we don't have good UT coverage everywhere in the Python-SDK, it might make sense to extends the UTs where the coverage is low (<50%). Tracking JIRA for that effort is BEAM-1680. |
No description provided.