Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type signature typo in Javadoc #2329

Closed
wants to merge 2 commits into from
Closed

Fix type signature typo in Javadoc #2329

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe33b3b
Fix type signature typo in Javadoc
wtanaka Mar 26, 2017
9eb8f55
Fix typo in FindAll javadoc
wtanaka Mar 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Regex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,8 @@ public void processElement(ProcessContext c) throws Exception {

/**
* {@code Regex.MatchesName<String>} takes a {@code PCollection<String>} and returns a {@code
* PCollection<String>} representing the value extracted from all the Regex groups of the input
* PCollection<List<String>>} representing the value extracted from all the
* Regex groups of the input
* {@code PCollection} to the number of times that element occurs in the input.
*
* <p>This transform runs a Regex on the entire input line. If the entire line does not match the
Expand All @@ -497,8 +498,8 @@ public void processElement(ProcessContext c) throws Exception {
*
* <pre>{@code
* PCollection<String> words = ...;
* PCollection<String> values =
* words.apply(Regex.matches("myregex (mygroup)"));
* PCollection<List<String>> values =
* words.apply(Regex.allMatches("myregex (mygroup)"));
* }</pre>
*/
public static class AllMatches
Expand Down Expand Up @@ -709,7 +710,8 @@ public void processElement(ProcessContext c) throws Exception {

/**
* {@code Regex.Find<String>} takes a {@code PCollection<String>} and returns a {@code
* PCollection<String>} representing the value extracted from the Regex groups of the input {@code
* PCollection<List<String>>} representing the value extracted from the
* Regex groups of the input {@code
* PCollection} to the number of times that element occurs in the input.
*
* <p>This transform runs a Regex on the entire input line. If a portion of the line does not
Expand All @@ -720,8 +722,8 @@ public void processElement(ProcessContext c) throws Exception {
*
* <pre>{@code
* PCollection<String> words = ...;
* PCollection<String> values =
* words.apply(Regex.find("myregex (mygroup)"));
* PCollection<List<String>> values =
* words.apply(Regex.findAll("myregex (mygroup)"));
* }</pre>
*/
public static class FindAll extends PTransform<PCollection<String>, PCollection<List<String>>> {
Expand Down