[BEAM-1828] Switched to using "destroy" instead of "unpersist" for broadcasts. #2355
Conversation
|
R: @amitsela |
|
Run Spark ValidatesRunner |
| @@ -131,7 +131,7 @@ public static void advance(JavaSparkContext jsc) { | |||
| if (broadcast != null) { | |||
| // for now this is blocking, we could make this asynchronous | |||
| // but it could slow down WM propagation. | |||
| broadcast.unpersist(true); | |||
| broadcast.destroy(true); | |||
There was a problem hiding this comment.
Default is true so you can drop the parameter if you want..
|
LGTM, added a minor comment but nothing of importance. |
staslev
changed the title
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Run Spark ValidatesRunner |
|
Refer to this link for build results (access rights to CI server needed): Failed Tests: 3beam_PostCommit_Java_ValidatesRunner_Spark/org.apache.beam:beam-runners-spark: 3
--none-- |
|
Refer to this link for build results (access rights to CI server needed): |
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.