Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified error message when GCSIO fails to upload file #24449

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

andreigurau
Copy link
Contributor

Made error message more clear when there is an error thrown when GCSIO is uploading a file


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #24449 (79394c2) into master (fd7e862) will increase coverage by 0.31%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master   #24449      +/-   ##
==========================================
+ Coverage   73.36%   73.68%   +0.31%     
==========================================
  Files         718      718              
  Lines       97034    98803    +1769     
==========================================
+ Hits        71193    72805    +1612     
- Misses      24511    24668     +157     
  Partials     1330     1330              
Flag Coverage Δ
python 83.22% <75.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/gcp/gcsio.py 93.66% <75.00%> (+1.53%) ⬆️
sdks/python/apache_beam/io/localfilesystem.py 90.97% <0.00%> (-0.76%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.24% <0.00%> (-0.33%) ⬇️
sdks/python/apache_beam/transforms/util.py 96.23% <0.00%> (-0.16%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.67% <0.00%> (-0.13%) ⬇️
...examples/inference/pytorch_image_classification.py 0.00% <0.00%> (ø)
...ference/pytorch_image_classification_benchmarks.py 0.00% <0.00%> (ø)
sdks/python/apache_beam/io/filebasedsource.py 99.11% <0.00%> (+0.23%) ⬆️
sdks/python/apache_beam/transforms/core.py 92.90% <0.00%> (+0.36%) ⬆️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @ryanthompson591 for label python.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@johnjcasey
Copy link
Contributor

Run Python PreCommit

@johnjcasey johnjcasey merged commit a88956b into apache:master Dec 5, 2022
lostluck pushed a commit to lostluck/beam that referenced this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants