Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1928] Use SdkComponents in WindowingStrategy.toProto #2490

Closed
wants to merge 2 commits into from

Conversation

tgroh
Copy link
Member

@tgroh tgroh commented Apr 11, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@tgroh
Copy link
Member Author

tgroh commented Apr 11, 2017

R: @dhalperi OR @lukecwik

This is a minor change to how we're currently translating windowing strategies, where we use an SdkComponents instead of building our own when trying to construct the MessageWithComponents

@asfbot
Copy link

asfbot commented Apr 11, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9399/
--none--

@tgroh tgroh force-pushed the windowing_strategies_components branch from ca61a6d to eaf51aa Compare April 11, 2017 18:21
@asfbot
Copy link

asfbot commented Apr 11, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9404/

Build result: FAILURE

[...truncated 1.16 MB...] at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)Caused by: org.apache.maven.plugin.compiler.CompilationFailureException: Compilation failure/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/sdks/java/io/hadoop/jdk1.8-tests/src/test/java/org/apache/beam/sdk/io/hadoop/inputformat/HIFIOWithEmbeddedCassandraTest.java:[29,57] package org.apache.beam.sdk.io.hadoop.inputformat.hashing does not exist at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1029) at org.apache.maven.plugin.compiler.TestCompilerMojo.execute(TestCompilerMojo.java:170) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 more2017-04-11T18:46:14.275 [ERROR] 2017-04-11T18:46:14.275 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-04-11T18:46:14.275 [ERROR] 2017-04-11T18:46:14.275 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-04-11T18:46:14.275 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException2017-04-11T18:46:14.275 [ERROR] 2017-04-11T18:46:14.275 [ERROR] After correcting the problems, you can resume the build with the command2017-04-11T18:46:14.275 [ERROR] mvn -rf :beam-sdks-java-io-hadoop-jdk1.8-testschannel stoppedSetting status of eaf51aa to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9404/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@dhalperi
Copy link
Contributor

LGTM, merge if green

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0e2ef1a on tgroh:windowing_strategies_components into ** on apache:master**.

@asfbot
Copy link

asfbot commented Apr 12, 2017

@tgroh
Copy link
Member Author

tgroh commented Apr 12, 2017

retest this please

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0e2ef1a on tgroh:windowing_strategies_components into ** on apache:master**.

@asfbot
Copy link

asfbot commented Apr 12, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9430/
--none--

@asfgit asfgit closed this in 571631a Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants