Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1383] Making metrics usage in datastore_wordcount consistent #2575

Closed
wants to merge 1 commit into from

Conversation

pabloem
Copy link
Member

@pabloem pabloem commented Apr 18, 2017

Modifying datastore_wordcount.py to create metrics within the __init__ method of the DoFn that uses them.
r: @aaltay

@aaltay
Copy link
Member

aaltay commented Apr 18, 2017

LGTM

@coveralls
Copy link

coveralls commented Apr 18, 2017

Coverage Status

Coverage increased (+18.9%) to 89.589% when pulling 157a3ee on pabloem:consistent-metrics into 686b774 on apache:master.

@asfgit asfgit closed this in 0e11a93 Apr 18, 2017
@pabloem pabloem deleted the consistent-metrics branch April 18, 2017 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants