Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WRITE_EMPTY disposition fail duplicate copy job #26608

Merged
merged 1 commit into from
May 15, 2023

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented May 9, 2023

Fixes #26587

Follow up of #24535

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #26608 (d050697) into master (0ac9fc1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #26608      +/-   ##
==========================================
+ Coverage   72.05%   72.07%   +0.02%     
==========================================
  Files         745      745              
  Lines      101223   101224       +1     
==========================================
+ Hits        72937    72962      +25     
+ Misses      26826    26802      -24     
  Partials     1460     1460              
Flag Coverage Δ
python 81.11% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/python/apache_beam/io/gcp/bigquery_file_loads.py 87.41% <100.00%> (+0.02%) ⬆️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Abacn
Copy link
Contributor Author

Abacn commented May 9, 2023

R: @robertwb

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn
Copy link
Contributor Author

Abacn commented May 15, 2023

timeout github action tests unrelated. merging for now

@Abacn Abacn merged commit edde37f into apache:master May 15, 2023
@Abacn Abacn deleted the fixwriteempty branch May 15, 2023 19:05
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: BigQuery Copy jobs do not set write disposition to WRITE_APPEND after first copy
2 participants