-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#27558] Update required Go version to 1.20. #27559
Conversation
Codecov Report
@@ Coverage Diff @@
## master #27559 +/- ##
==========================================
- Coverage 71.14% 71.13% -0.02%
==========================================
Files 861 859 -2
Lines 104560 104506 -54
==========================================
- Hits 74389 74338 -51
+ Misses 28621 28610 -11
- Partials 1550 1558 +8
Flags with carried forward coverage won't be shown. Click here to find out more. see 28 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run Go PreCommit |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
There's an issue with Go 1.20.6 and test containers (among other socket users): testcontainers/testcontainers-go#1359 with the go bug tracked at |
The github actions will start failing on this, and due to this being a breaking behavioral change that also affects Kubernetes, I expect we'll see a 1.20.7 sometime this week. This doesn't block other work related to setting prism as default, so I'll be getting other PRs out shortly. |
Docker v24.0.5 release https://github.com/moby/moby/releases/tag/v24.0.5 fixes it's issue with go1.20.6, which should unblock this PR. |
Run Java PreCommit |
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also pulls the builds to the latest patch release for Go 1.20.6 (released on July 11th).
Fixes #27558.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.