Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick: Revert #27878 (#27968) #27970

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

damccorm
Copy link
Contributor

  • Merge in master

  • Remove changes.md callout

This introduced some breaking changes to our gcs client


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

* Merge in master

* Remove changes.md callout
@damccorm
Copy link
Contributor Author

R: @johnjcasey @lostluck

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@damccorm
Copy link
Contributor Author

R: @johnjcasey @liferoad @lostluck

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-2.50.0@8caa7ce). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release-2.50.0   #27970   +/-   ##
=================================================
  Coverage                  ?   72.30%           
=================================================
  Files                     ?      678           
  Lines                     ?    99643           
  Branches                  ?        0           
=================================================
  Hits                      ?    72050           
  Misses                    ?    26034           
  Partials                  ?     1559           
Flag Coverage Δ
python 82.85% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@liferoad liferoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure our tests can fine before merging. Thanks!

@johnjcasey
Copy link
Contributor

LGTM

@lostluck lostluck merged commit 50e2495 into release-2.50.0 Aug 11, 2023
82 of 84 checks passed
@damccorm damccorm deleted the users/damccorm/revert-cp branch August 11, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants