Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Python]Don't stage beam SDK in Stager" #28094

Closed
wants to merge 1 commit into from

Conversation

damccorm
Copy link
Contributor

Reverts #27436

This is causing issues in RC validation (addresses #28084)

@damccorm
Copy link
Contributor Author

R: @tvalentyn @AnandInguva @lostluck

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #28094 (ace89c9) into master (a46a35b) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #28094      +/-   ##
==========================================
+ Coverage   72.30%   72.32%   +0.01%     
==========================================
  Files         678      678              
  Lines       99775    99759      -16     
==========================================
+ Hits        72147    72154       +7     
+ Misses      26065    26042      -23     
  Partials     1563     1563              
Flag Coverage Δ
go 53.71% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...dks/python/apache_beam/options/pipeline_options.py 94.53% <ø> (ø)
...s/python/apache_beam/runners/portability/stager.py 84.22% <ø> (-0.17%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tvalentyn
Copy link
Contributor

tvalentyn commented Aug 22, 2023

discussed offline, working on a simple fix-forward PR

@damccorm damccorm closed this Aug 22, 2023
@damccorm damccorm reopened this Aug 22, 2023
@damccorm
Copy link
Contributor Author

(leaving open in case there are issues with the forward fix)

@damccorm damccorm closed this Aug 22, 2023
@damccorm damccorm deleted the revert-27436-unstage_sdk branch August 22, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants