-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hdfs integration test #30458
Fix hdfs integration test #30458
Conversation
The error is
See https://github.com/apache/beam/actions/runs/8100844372/job/22139914281 |
Caused by #29834 |
Another breakage after revert #29834:
This is due to #30198. However, the change was earlier and the test succeeded at that time. What happened is that I commented out other test suites and just run hdfsIntegrationTest then install fails. |
debug only skip yaml test
@@ -516,7 +516,6 @@ tasks.register("python38PostCommit") { | |||
tasks.register("python39PostCommit") { | |||
dependsOn(":sdks:python:test-suites:dataflow:py39:postCommitIT") | |||
dependsOn(":sdks:python:test-suites:direct:py39:postCommitIT") | |||
dependsOn(":sdks:python:test-suites:direct:py39:hdfsIntegrationTest") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to run hdfsIntegrationTest only in lowest and highest Python version as the functionality didn't change for long but has a history of broken due to unrelated change. If it is broken at least there are green signal for Python 3.9 / 3.10 so does not undermine other breakage signal
R: @ahmedabu98 |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sounds good to me. Also, checked the python 3.8 results and it is not failing for hdfs test anymore. Thank you!
(I think the other failures are unrelated, probably sync with master)
Python PreCommit passed. Python Test need rebase to pass, otherwise good for now |
Fix #30459
For some reason there are connection refused error between test_node, name_node and data_node. Might due to recent upgrade of Python official docker image (base image upgrade)
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.