Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FLOAT32 type in Spanner #30893

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

arawind
Copy link
Contributor

@arawind arawind commented Apr 8, 2024

Adds support for the newly added FLOAT32 type in Google Cloud Spanner.

Since FLOAT was already mapped to FLOAT64, this change modifies the existing mapping to FLOAT -> FLOAT32 instead.

Addresses #30700.

Please ignore the commit bumping the BOM version to 26.36.0. This is already being done as part of #30868


Build python source distribution and wheels
Python tests
Java tests
Go tests

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@arawind
Copy link
Contributor Author

arawind commented Apr 10, 2024

assign set of reviewers

(The single failure is due to a socket timeout, which seems flaky as it wasn't there in the previous run; I'll anyway rerun the tests by rebasing on HEAD)

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas for label java.
R: @damondouglas for label io.
R: @nielm for label spanner.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@nielm
Copy link
Contributor

nielm commented Apr 10, 2024

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants