Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yaml] Add examples for Spanner IO in YAML #32288

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

reeba212
Copy link
Contributor

Added examples with explanatory comments for reading from and writing to a spanner table


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@reeba212 reeba212 changed the title Add examples for Spanner IO in YAML [yaml] Add examples for Spanner IO in YAML Aug 22, 2024
Copy link
Contributor

@Polber Polber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a couple comments, but overall looks good! Thanks

sdks/python/apache_beam/yaml/examples/spanner_read.yaml Outdated Show resolved Hide resolved
Comment on lines 11 to 13
project_id: 'apache-beam-testing'
instance_id: 'shipment-test'
database_id: 'shipment'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damccorm Are Spanner resources (specifically these) exposed to general public? i.e., would anyone be able to run this YAML as-is?

sdks/python/apache_beam/yaml/examples/spanner_read.yaml Outdated Show resolved Hide resolved
sdks/python/apache_beam/yaml/examples/spanner_write.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

@Polber Polber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment, thanks!

1. Add good element in spanner write example to pass checks.
2. Remove spanner examples from examples_test.py for the time being.
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.31%. Comparing base (2573106) to head (92f8d24).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #32288      +/-   ##
============================================
- Coverage     57.32%   57.31%   -0.02%     
  Complexity     1474     1474              
============================================
  Files           965      965              
  Lines        153454   153454              
  Branches       1076     1076              
============================================
- Hits          87974    87956      -18     
- Misses        63276    63294      +18     
  Partials       2204     2204              
Flag Coverage Δ
python 81.50% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn
Copy link
Contributor

R: @Polber

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@Polber Polber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple comments for fixing tests. I think other test failures are unrelated

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 9f8a4b2 into apache:master Sep 16, 2024
105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants