Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#28187] Add gradle targets to execute python tests with prism. #32637

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Oct 2, 2024

  • Copies the Flink equivalent tasks.
  • Validated that the validatesRunnerTests build and pass (assuming you have all the Python set up)
    • Sickbayed / skipped the 3 remaining failing tests around CustomWindows and Coders for now.
  • Added target for iterating against trigger semantics. Will eventually be part of the PreCommit.

This is a required task before adding a Precommit action for running the Python suites against prism. That work will be in a separate PR.

A part of #28187.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.84%. Comparing base (301286f) to head (201bdb9).
Report is 34 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #32637   +/-   ##
=========================================
  Coverage     58.84%   58.84%           
  Complexity     3091     3091           
=========================================
  Files          1130     1130           
  Lines        174044   174048    +4     
  Branches       3320     3312    -8     
=========================================
+ Hits         102414   102422    +8     
- Misses        68293    68295    +2     
+ Partials       3337     3331    -6     
Flag Coverage Δ
python 81.41% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @shunping for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@shunping shunping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Are we going to trigger these validation tests in any github action?

@lostluck
Copy link
Contributor Author

lostluck commented Oct 7, 2024

@shunping yup! I just wanted that in a separate PR, as mentioned in the PR description.

@lostluck lostluck merged commit 8919950 into apache:master Oct 7, 2024
96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants